rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r336605079
##########
File path: core/src/main/java/org/apache/iceberg/PartitionSpecParser.java
##########
@@ -36,11 +36,12 @@
private PartitionSpecParser() {
}
+ private static final String NAME = "name";
private static final String SPEC_ID = "spec-id";
private static final String FIELDS = "fields";
private static final String SOURCE_ID = "source-id";
+ private static final String PARTITION_FIELD_ID = "partition-field-id";
Review comment:
I think "field-id" is fine here. The "partition" part is clear from context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
