rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r476848415
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -380,58 +381,74 @@ public Builder identity(String sourceName) {
return identity(sourceName, sourceName);
}
- public Builder year(String sourceName, String targetName) {
+ public Builder year(String sourceName, String targetName, ZoneOffset
zoneOffset) {
Review comment:
I would rather not expose Java's time library in Iceberg's API. Could we
use a string instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
