rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r476855472
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Transforms.java
##########
@@ -154,9 +182,13 @@ private Transforms() {
*/
@SuppressWarnings("unchecked")
public static <T> Transform<T, Integer> hour(Type type) {
+ return hour(type, ZoneOffset.UTC);
+ }
+
+ public static <T> Transform<T, Integer> hour(Type type, ZoneOffset
zoneOffset) {
Preconditions.checkArgument(type.typeId() == Type.TypeID.TIMESTAMP,
- "Cannot partition type %s by hour", type);
- return (Transform<T, Integer>) Timestamps.HOUR;
+ "Cannot partition type %s by hour", type);
Review comment:
Nit: This is an unnecessary change to indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
