rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r476851581
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Transforms.java
##########
@@ -40,6 +41,7 @@ private Transforms() {
}
private static final Pattern HAS_WIDTH =
Pattern.compile("(\\w+)\\[(\\d+)\\]");
+ private static final Pattern HAS_TIME_OFFSET =
Pattern.compile("(\\w+)\\[(\\-?\\d+)\\]");
Review comment:
The pattern should require either `-` or `+`, and should also require
2-digit values for hour and minute. Using hour/minute instead of seconds makes
this much easier to read and work with for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
