rdblue commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r476854186
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Transforms.java
##########
@@ -94,14 +110,18 @@ private Transforms() {
*/
@SuppressWarnings("unchecked")
public static <T> Transform<T, Integer> year(Type type) {
+ return year(type, ZoneOffset.UTC);
+ }
+
+ public static <T> Transform<T, Integer> year(Type type, ZoneOffset
zoneOffset) {
Review comment:
The cases for `date` need to assert that the offset is either null or
UTC. I don't think it makes sense for a date to use the offset, so if there is
an offset it should be rejected and not ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
