pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479607714
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -296,7 +319,10 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties) {
properties.forEach(key -> parameter.put(key, null));
Database database = convertToDatabase(namespace, parameter);
- return alterHiveDataBase(namespace, database);
+ boolean result = alterHiveDataBase(namespace, database);
+ LOG.debug("Remove properties: {} from: {} resulted: {}", properties,
namespace, result);
Review comment:
Removed the alterHiveDataBase method return value, since it is a private
function and as you correctly pointed out never returns false.
Tried to find the usages of the HiveCatalog.setProperties/removeProperties
method, and followed the call stack a few steps, but did not find any logs
around that. (I might missed something)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
