rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479509408
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -63,7 +66,10 @@ private TableIdentifier
canonicalizeIdentifier(TableIdentifier tableIdentifier)
@Override
public Table loadTable(TableIdentifier ident) {
- return tableCache.get(canonicalizeIdentifier(ident), catalog::loadTable);
+ Table result = tableCache.get(canonicalizeIdentifier(ident),
catalog::loadTable);
+ LOG.info("Table loaded by catalog: {}", result);
Review comment:
Well, a cache hit could just be the absence of a log message. But you
could also inject an atomic boolean in the load table call that is passed to
the cache. If it gets called, it sets the boolean to true. Then the log only
triggers if it was not called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
