rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479508968
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -296,7 +319,10 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties) {
properties.forEach(key -> parameter.put(key, null));
Database database = convertToDatabase(namespace, parameter);
- return alterHiveDataBase(namespace, database);
+ boolean result = alterHiveDataBase(namespace, database);
+ LOG.debug("Remove properties: {} from: {} resulted: {}", properties,
namespace, result);
Review comment:
If not logging the properties, then what is the value of this log? If
the query fails, it will throw an exception so the only time this will run is
when the result is `true`. That doesn't seem useful to me, considering this is
called from an operation that probably logs itself, like `updateProperties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
