rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479695372
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -300,17 +300,11 @@ public boolean setProperties(Namespace namespace,
Map<String, String> propertie
parameter.putAll(properties);
Database database = convertToDatabase(namespace, parameter);
- boolean result = alterHiveDataBase(namespace, database);
+ alterHiveDataBase(namespace, database);
+ LOG.debug("Successfully set properties for {}", namespace);
Review comment:
This log doesn't seem useful to me since it doesn't have any information
other than the method reached this point. It should be clear from other places
(e.g., the SQL statement that ran) what was called. And we know it is
successful or else an error is logged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
