pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479728173
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -300,17 +300,11 @@ public boolean setProperties(Namespace namespace,
Map<String, String> propertie
parameter.putAll(properties);
Database database = convertToDatabase(namespace, parameter);
- boolean result = alterHiveDataBase(namespace, database);
+ alterHiveDataBase(namespace, database);
+ LOG.debug("Successfully set properties for {}", namespace);
Review comment:
First I removed the logs, but then thought better of it.
Added it back with the list of the name of the properties we decided to set.
This way we will at least know how the
SparkCatalog.alterNamespace/FlinkCatalog.alterNamespace classified the
properties, and which one was removed which one was set instead.
Do you think it is worthwhile to log this way?
I kinda feel that I have dragged on too much on your patience, so one last
request and I will remove both log lines from the code.
Thanks again!
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
