rdblue commented on a change in pull request #1353:
URL: https://github.com/apache/iceberg/pull/1353#discussion_r482616093
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -284,6 +284,8 @@ public String toString() {
private Schema lazyColumnProjection() {
Collection<String> selectedColumns = context.selectedColumns();
if (selectedColumns != null) {
+ // select columns only works for data table scans, so it is OK to select
on table.schema().
+
Review comment:
I don't understand why select only works for data table scans. I updated
this method to use the `schema` that is passed into the constructor and all
Iceberg tests pass. By updating this to use the schema passed in instead of the
table schema, we can support either project or select, depending on what the
caller chooses.
Then we can remove the overrides that throw `UnsupportedOperationException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
