rdblue commented on a change in pull request #1353:
URL: https://github.com/apache/iceberg/pull/1353#discussion_r483058492
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -106,6 +106,14 @@ protected abstract TableScan newRefinedScan(
TableOperations ops, Snapshot snapshot, Expression rowFilter,
boolean ignoreResiduals, boolean caseSensitive, boolean colStats);
+ /**
+ * The {@link #filter(Expression)} is based on the table records. So the
data table scan need select all of the
+ * filter columns, other scans don't need to.
+ */
+ protected boolean isDataTableScan() {
Review comment:
I'm not sure I understand why this is added. Shouldn't the filter (which
is unbound) be bound to the scan's schema and not the underlying table's schema?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
