JingsongLi commented on pull request #1353:
URL: https://github.com/apache/iceberg/pull/1353#issuecomment-686863138


   Sorry, It seems that I misunderstood it.
   Is the filter applied to the schema of scan or the schema of table?
   For example, a table schema: {id -> int, data -> string}, but the schema of 
a `FilesTableScan` is {content -> int, file_path -> string, file_size -> long, 
....}. (Defined in `DataFile`)
   
   So IIUC, filters on `FilesTableScan` should be `file_path=...` or 
`file_size>.. and file_size<...`. I got it wrong because there was something 
wrong with the sample in the test class: `TestMetadataTableScans`, in this 
class, all filters on id...
   
   I'll change the code and fix the tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to