JingsongLi commented on a change in pull request #1353:
URL: https://github.com/apache/iceberg/pull/1353#discussion_r482682916
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -284,6 +284,8 @@ public String toString() {
private Schema lazyColumnProjection() {
Collection<String> selectedColumns = context.selectedColumns();
if (selectedColumns != null) {
+ // select columns only works for data table scans, so it is OK to select
on table.schema().
+
Review comment:
The problem is on `rowFilter`.
IIUC, `rowFilter` is based on table data for every scans, so:
- if it is data table scan, we should add the field ids of `rowFilter` to
`requiredFieldIds`.
- if it is not data table scan, we should not, because the schema not
contains fields of `rowFilter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
