rdblue commented on a change in pull request #1353:
URL: https://github.com/apache/iceberg/pull/1353#discussion_r483058990
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -286,21 +294,26 @@ private Schema lazyColumnProjection() {
if (selectedColumns != null) {
Set<Integer> requiredFieldIds = Sets.newHashSet();
- // all of the filter columns are required
- requiredFieldIds.addAll(
- Binder.boundReferences(table.schema().asStruct(),
- Collections.singletonList(context.rowFilter()),
context.caseSensitive()));
+ if (isDataTableScan()) {
Review comment:
Why not do this for all table scans?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
