kbendick commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483932570
##########
File path: api/src/main/java/org/apache/iceberg/Files.java
##########
@@ -60,9 +60,8 @@ public PositionOutputStream create() {
if (!file.getParentFile().isDirectory() &&
!file.getParentFile().mkdirs()) {
throw new RuntimeIOException(
- String.format(
"Failed to create the file's directory at %s.",
- file.getParentFile().getAbsolutePath()));
+ file.getParentFile().getAbsolutePath());
Review comment:
I personally feel that replacing deprecated exceptions is out of scope
for this PR. I think it would be cleaner / easier if the deprecated exception
was replaced in another PR in one go or just left as is for now. As it stands,
the PR is already 71 files changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
