jzhuge commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483983340
##########
File path: api/src/main/java/org/apache/iceberg/Files.java
##########
@@ -76,7 +75,7 @@ public PositionOutputStream create() {
public PositionOutputStream createOrOverwrite() {
if (file.exists()) {
if (!file.delete()) {
- throw new RuntimeIOException("Failed to delete: " + file);
+ throw new RuntimeIOException("Failed to delete: %s", file);
Review comment:
Thanks for the clarification!
> Probably the best answer / tldr is that it's better because the linting
automation enforces it currently and it brings standardization to the code base.
Make sense.
For rarely travelled code paths, I hope developers do not have to invest too
much time tuning performance. Often compiler and GC already do a good enough
job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
