RussellSpitzer commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483952091



##########
File path: build.gradle
##########
@@ -174,6 +174,7 @@ project(':iceberg-bundled-guava') {
 project(':iceberg-api') {
   dependencies {
     compile project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+    compileOnly "com.google.errorprone:error_prone_annotations:2.3.3"

Review comment:
       I'm not sure what you mean, the palanrir baseline plugin is turning in 
both spotbugs and errorprone in Gradle. It just doesn't include the libraries 
as compile time dependencies for modules since they aren't needed unless you 
use annotations.
   
   I do think once we hit 0 warnings we should switch it to test warnings as 
errors




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to