RussellSpitzer commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483952472
##########
File path: api/src/main/java/org/apache/iceberg/Files.java
##########
@@ -76,7 +75,7 @@ public PositionOutputStream create() {
public PositionOutputStream createOrOverwrite() {
if (file.exists()) {
if (!file.delete()) {
- throw new RuntimeIOException("Failed to delete: " + file);
+ throw new RuntimeIOException("Failed to delete: %s", file);
Review comment:
Yeah the main reason here is like Kyle said,
t
The linter can't check a non effectively final format string. This is
because the linter can't check at compile time whether or not the string is
valid.
This is a case where we were basically calling format on the result of
another format method with the exact same args. So the solution that makes the
most sense is just eliminating the unneeded format call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
