kbendick commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483931323
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -102,7 +102,7 @@ public Table load(String location) {
*/
private Pair<String, MetadataTableType> parseMetadataType(String location) {
int hashIndex = location.lastIndexOf('#');
- if (hashIndex != -1 & !location.endsWith("#")) {
+ if (hashIndex != -1 && !location.endsWith("#")) {
Review comment:
Brilliant. If we're going to consider enabling any more required rules,
can something be done to better lint usages of boolean `&&` vs the bit
operation? I imagine there's a rule for disallow implicit integer type
conversions to boolean or better yet to disallow bitwise operator in an if
statement or the like? That could be handled in a separate PR / issue (I'd be
happy to look into it if you don't know off the top of your head).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
