nastra commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2526559974
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
this is for rows and we're looking for a lower bound, hence why we're having
the `min` in the name. We're open to better naming suggestions, but using
something with `limit` in the name rather implies an upper bound, which
wouldn't be correct here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
