stevenzwu commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2528306781
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
@nastra lower bound may not always be valid. e.g. maybe the table just don't
have enough number of rows to satisfy the lower bound.
`target` is probably a good name for the desired plan size. Wondering why
not using `bytes` (instead of `rows`) to express the target, similar to
`read.split.target-size`?
Anyway, I would suggest `target-plan-size-rows` or `target-plan-size-bytes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
