amogh-jahagirdar commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2535394787
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
Yeah I don't think we want to do bytes, this is ultimately for allowing
engines to have any easy way to express a limit so that we limit the amount of
work that needs to be done on a server.
IMO, after going through this thread, I think I still find the most
compelling option to be what I proposed earlier, `limit-hint`. I think that
this naming best indicates to a client what the intent is ("To express a limit
to the server") and that it's a hint. I also found out that there's some prior
art on this naming here as it looks like the Delta Protocol naming for this
concept is also called limitHint.
https://github.com/delta-io/delta-sharing/blob/main/PROTOCOL.md#request-body
I'm also good with the current PR's `min-rows-requested`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
