stevenzwu commented on code in PR #14565:
URL: https://github.com/apache/iceberg/pull/14565#discussion_r2535551587
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1439,6 +1439,11 @@ class PlanTableScanRequest(BaseModel):
filter: Optional[Expression] = Field(
None, description='Expression used to filter the table data'
)
+ min_rows_requested: Optional[int] = Field(
Review Comment:
I misunderstood the purpose of this config. I thought it was for the target
size of the `PlanTask`s from the PlanTableScan, similar to the
`read.split.target-size`.
Didn't realize it is for the limit push down. I am fine with either
`min-rows-requested` or `limit-hint. slight preference for `min-rows-requested`
since it is more descriptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
