zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2550022067
##########
src/iceberg/metrics.h:
##########
@@ -32,12 +32,12 @@ namespace iceberg {
/// \brief Iceberg file format metrics
struct ICEBERG_EXPORT Metrics {
int64_t row_count = 0;
Review Comment:
DataFile.record_count is a pure int64_t, I guess it's ok here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
