zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2556411429
##########
src/iceberg/manifest_list.h:
##########
@@ -218,21 +224,21 @@ struct ICEBERG_EXPORT ManifestList {
};
/// \brief Get the relative manifest content type name
-ICEBERG_EXPORT constexpr std::string_view ToString(ManifestFile::Content type)
noexcept {
+ICEBERG_EXPORT constexpr std::string_view ToString(ManifestContent type)
noexcept {
switch (type) {
- case ManifestFile::Content::kData:
+ case ManifestContent::kData:
return "data";
- case ManifestFile::Content::kDeletes:
+ case ManifestContent::kDeletes:
return "deletes";
}
std::unreachable();
}
/// \brief Get the relative manifest content type from name
-ICEBERG_EXPORT constexpr Result<ManifestFile::Content>
ManifestFileContentFromString(
+ICEBERG_EXPORT constexpr Result<ManifestContent> ManifestContentFromString(
Review Comment:
I'm a bit confused here, are you worried that this function will be included
in multiple translation units?
If so, `constexpr` implies `inline`, so this should be fine. We already use
this pattern in several other places, correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
