zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2556328423
##########
src/iceberg/manifest_adapter.cc:
##########
@@ -161,6 +164,110 @@ ManifestEntryAdapter::~ManifestEntryAdapter() {
}
}
+Status ManifestEntryAdapter::AddEntry(ManifestEntry& entry) {
+ ICEBERG_RETURN_UNEXPECTED(CheckDataFile(*entry.data_file));
+ entry.status = ManifestStatus::kAdded;
+ entry.snapshot_id = snapshot_id_;
+ if (entry.sequence_number.has_value() &&
+ entry.sequence_number.value() < TableMetadata::kInitialSequenceNumber) {
+ entry.sequence_number = std::nullopt;
Review Comment:
This logic has been removed since GetSequenceNumber handle this, the reason
for it been null is because for newly added data, its sequence number is
inherited from manifest metadata, see [1].
[1] https://iceberg.apache.org/spec/#sequence-number-inheritance
##########
src/iceberg/manifest_adapter.cc:
##########
@@ -161,6 +164,110 @@ ManifestEntryAdapter::~ManifestEntryAdapter() {
}
}
+Status ManifestEntryAdapter::AddEntry(ManifestEntry& entry) {
+ ICEBERG_RETURN_UNEXPECTED(CheckDataFile(*entry.data_file));
+ entry.status = ManifestStatus::kAdded;
+ entry.snapshot_id = snapshot_id_;
+ if (entry.sequence_number.has_value() &&
+ entry.sequence_number.value() < TableMetadata::kInitialSequenceNumber) {
+ entry.sequence_number = std::nullopt;
+ }
+ entry.file_sequence_number = std::nullopt;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
