evindj commented on code in PR #608:
URL: https://github.com/apache/iceberg-cpp/pull/608#discussion_r3010383607
##########
src/iceberg/test/roaring_position_bitmap_test.cc:
##########
@@ -128,9 +128,72 @@ INSTANTIATE_TEST_SUITE_P(
.start = (int64_t{1} << 32) - 5,
.end = (int64_t{1} << 32) + 5,
.absent_positions = {0, (int64_t{1} << 32) + 5},
+ },
+ AddRangeParams{
+ .name = "single_position",
+ .start = 42,
+ .end = 43,
+ .absent_positions = {41, 43},
}),
[](const ::testing::TestParamInfo<AddRangeParams>& info) { return
info.param.name; });
+TEST(RoaringPositionBitmapTest, TestAddRangeLargeContiguous) {
+ RoaringPositionBitmap bitmap;
+ bitmap.AddRange(500, 200500);
+
+ ASSERT_EQ(bitmap.Cardinality(), 200000u);
+ ASSERT_TRUE(bitmap.Contains(500));
+ ASSERT_TRUE(bitmap.Contains(200499));
+ ASSERT_FALSE(bitmap.Contains(499));
+ ASSERT_FALSE(bitmap.Contains(200500));
+}
+
+TEST(RoaringPositionBitmapTest, TestAddRangeSpanningThreeKeys) {
+ RoaringPositionBitmap bitmap;
+
+ int64_t start = (int64_t{0} << 32) | int64_t{0xFFFFFFF0};
+ int64_t end = (int64_t{2} << 32) | int64_t{0x10};
+ bitmap.AddRange(start, end);
+
+ ASSERT_EQ(bitmap.Cardinality(), static_cast<size_t>(end - start));
+ ASSERT_TRUE(bitmap.Contains(start));
+ ASSERT_TRUE(bitmap.Contains(end - 1));
+ ASSERT_FALSE(bitmap.Contains(start - 1));
+ ASSERT_FALSE(bitmap.Contains(end));
+ ASSERT_TRUE(bitmap.Contains(int64_t{1} << 32));
+ // Verify a sample near the end of the middle key is also present
+ ASSERT_TRUE(bitmap.Contains((int64_t{1} << 32) | int64_t{0xFFFFFFF0}));
+}
+
+TEST(RoaringPositionBitmapTest, TestAddRangeInvalidNegativeStartIsNoOp) {
+ RoaringPositionBitmap bitmap;
+ bitmap.AddRange(-1, 10);
+ ASSERT_TRUE(bitmap.IsEmpty());
+ ASSERT_EQ(bitmap.Cardinality(), 0u);
+}
+
+TEST(RoaringPositionBitmapTest, TestAddRangeInvalidBeyondMaxPositionIsNoOp) {
+ RoaringPositionBitmap bitmap;
+ bitmap.AddRange(0, RoaringPositionBitmap::kMaxPosition + 2);
+ ASSERT_TRUE(bitmap.IsEmpty());
+ ASSERT_EQ(bitmap.Cardinality(), 0u);
+}
+
+TEST(RoaringPositionBitmapTest, TestAddRangeReversedIsNoOp) {
+ RoaringPositionBitmap bitmap;
+ bitmap.AddRange(100, 50);
+ ASSERT_TRUE(bitmap.IsEmpty());
+ ASSERT_EQ(bitmap.Cardinality(), 0u);
+}
+
+TEST(RoaringPositionBitmapTest, TestAddRangeEqualStartEndIsNoOp) {
+ RoaringPositionBitmap bitmap;
+ bitmap.AddRange(100, 100);
+ ASSERT_TRUE(bitmap.IsEmpty());
+ ASSERT_EQ(bitmap.Cardinality(), 0u);
+ ASSERT_FALSE(bitmap.Contains(100));
+}
Review Comment:
could parameterize these noop tests.
##########
src/iceberg/deletes/roaring_position_bitmap.cc:
##########
@@ -128,8 +128,31 @@ void RoaringPositionBitmap::Add(int64_t pos) {
}
void RoaringPositionBitmap::AddRange(int64_t pos_start, int64_t pos_end) {
- for (int64_t pos = pos_start; pos < pos_end; ++pos) {
- Add(pos);
+ if (pos_start >= pos_end) {
+ return;
+ }
+ if (pos_start < 0 || pos_end - 1 > kMaxPosition) {
+ return;
+ }
Review Comment:
Nit: keep only one ```if``` block?
##########
src/iceberg/deletes/roaring_position_bitmap.h:
##########
@@ -65,6 +65,7 @@ class ICEBERG_EXPORT RoaringPositionBitmap {
void Add(int64_t pos);
/// \brief Sets a range of positions [pos_start, pos_end).
+ /// If pos_start >= pos_end, this method does nothing.
/// \note Invalid positions are silently ignored
Review Comment:
rephrase may be state pos_start >= pos_end is considered invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
