Baunsgaard commented on PR #608: URL: https://github.com/apache/iceberg-cpp/pull/608#issuecomment-4162176815
Thanks for the reviews! Addressed all feedback, let me know if i missed anything or any changes are required. As a reminder the related PRs are: - Java: https://github.com/apache/iceberg/pull/15791 - Rust: https://github.com/apache/iceberg-rust/pull/2292 ### Benchmark results I was asked for Benchmark results so i thought i would post some on each PR. `AddRange()` (native CRoaring `addRange`) vs a loop of individual `Add()` calls (Release build, GCC 14, 5 iterations after 3 warmup): | Scenario | Before (Add loop) | After (AddRange) | Speedup | |---|---|---|---| | 100 positions | 1.1 µs | 73.6 ns | **15x** | | 10k positions | 91.1 µs | 70.6 ns | **1,290x** | | 200k positions | 1.60 ms | 188.2 ns | **8,475x** | | 1M positions | 8.80 ms | 634.2 ns | **13,880x** | | 10k cross-key boundary | 97.3 µs | 102.4 ns | **951x** | > The cross-key boundary scenario inserts 10k positions spanning the 32-bit key boundary (e.g., `(1LL << 32) - 5000` to `(1LL << 32) + 5000`). This exercises the key-splitting logic where the range is divided across two internal 32-bit Roaring bitmaps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
