Baunsgaard commented on code in PR #608:
URL: https://github.com/apache/iceberg-cpp/pull/608#discussion_r3015434213
##########
src/iceberg/deletes/roaring_position_bitmap.h:
##########
@@ -65,6 +65,7 @@ class ICEBERG_EXPORT RoaringPositionBitmap {
void Add(int64_t pos);
/// \brief Sets a range of positions [pos_start, pos_end).
+ /// If pos_start >= pos_end, this method does nothing.
/// \note Invalid positions are silently ignored
Review Comment:
I have made it invalid if pos_start > pos_end, technically I can imagine
cases where pos_start == pos_end, therefore i keep that as a no-op.
Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
