emkornfield commented on code in PR #608:
URL: https://github.com/apache/iceberg-cpp/pull/608#discussion_r3010816641
##########
src/iceberg/deletes/roaring_position_bitmap.cc:
##########
@@ -128,8 +128,31 @@ void RoaringPositionBitmap::Add(int64_t pos) {
}
void RoaringPositionBitmap::AddRange(int64_t pos_start, int64_t pos_end) {
- for (int64_t pos = pos_start; pos < pos_end; ++pos) {
- Add(pos);
+ if (pos_start >= pos_end) {
+ return;
+ }
+ if (pos_start < 0 || pos_end - 1 > kMaxPosition) {
+ return;
+ }
+
+ int32_t start_key = Key(pos_start);
+ int32_t end_key = Key(pos_end - 1);
+ impl_->AllocateBitmapsIfNeeded(end_key + 1);
+
+ if (start_key == end_key) {
Review Comment:
I think it might end up being more maintainable to have a single loop that
handles both cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
