Baunsgaard commented on code in PR #608:
URL: https://github.com/apache/iceberg-cpp/pull/608#discussion_r3015439639
##########
src/iceberg/deletes/roaring_position_bitmap.cc:
##########
@@ -128,8 +128,31 @@ void RoaringPositionBitmap::Add(int64_t pos) {
}
void RoaringPositionBitmap::AddRange(int64_t pos_start, int64_t pos_end) {
- for (int64_t pos = pos_start; pos < pos_end; ++pos) {
- Add(pos);
+ if (pos_start >= pos_end) {
+ return;
+ }
+ if (pos_start < 0 || pos_end - 1 > kMaxPosition) {
Review Comment:
Okay, i follow the style of the normal operation, to ignore invalid
positions, and clamp inputs to correct values.
However, this is inconsistent with the behaviour of core Java, where
positions gets validated, and errors out if they are out of range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
