rdblue commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533753738
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/data/FlinkSchemaVisitor.java
##########
@@ -29,42 +29,43 @@
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
+import org.apache.orc.TypeDescription;
abstract class FlinkSchemaVisitor<T> {
- static <T> T visit(RowType flinkType, Schema schema, FlinkSchemaVisitor<T>
visitor) {
- return visit(flinkType, schema.asStruct(), visitor);
+ static <T> T visit(RowType flinkType, Schema schema, TypeDescription
typeDesc, FlinkSchemaVisitor<T> visitor) {
Review comment:
I think it would be cleaner to add the `beforeField`/`afterField`
callbacks instead of the `typeDesc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
