rdblue commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533754607
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java
##########
@@ -114,6 +120,7 @@ private static Metrics buildOrcMetrics(final long
numOfRows, final TypeDescripti
columnSizes,
valueCounts,
nullCounts,
+ Maps.newHashMap(),
Review comment:
Why not use null when metrics are missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
