rdblue commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533745327
##########
File path: api/src/main/java/org/apache/iceberg/NaNOnlyFieldMetrics.java
##########
@@ -17,51 +17,50 @@
* under the License.
*/
-package org.apache.iceberg.parquet;
Review comment:
Does this need to be in API or could it be in `core` instead?
If the class is never returned to users, then I would keep it in core. The
classes in `api` are primarily those that users would interact with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
