jackye1995 commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r536366260
########## File path: api/src/main/java/org/apache/iceberg/catalog/CatalogConfigurable.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.catalog; + +import java.util.Map; + +/** + * Interface to implement if the class will be initialized during dynamic catalog loading in engines like Spark. + * <p> + * When {@link Catalog#initialize(String catalogName, Map catalogProperties)} is called, + * The same catalog properties map is passed in to {@link CatalogConfigurable#initialize(Map catalogProperties)} + * to cascadingly complete the full catalog loading process. + */ +public interface CatalogConfigurable { Review comment: The reason I name it `CatalogConfigurable` is that Hadoop has its configurable interface called `Configurable` and it causes class name duplication. And I put it in the catalog package to not confuse the properties here with table properties. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
