danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r536225471
########## File path: aws/src/main/java/org/apache/iceberg/aws/AssumeRoleClientConfigFactory.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.util.Map; +import java.util.UUID; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.PropertyUtil; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; +import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder; +import software.amazon.awssdk.regions.Region; +import software.amazon.awssdk.services.sts.StsClientBuilder; +import software.amazon.awssdk.services.sts.auth.StsAssumeRoleCredentialsProvider; +import software.amazon.awssdk.services.sts.model.AssumeRoleRequest; + +/** + * Example of {@link AwsClientConfigFactory} for the assume role use case. + */ +public class AssumeRoleClientConfigFactory implements AwsClientConfigFactory { Review comment: I'm somewhat mixed on whether we want to include this in Iceberg. At a high-level, we want to leave as much AWS client configuration outside of Iceberg as possible (this allows for more flexibility without adding configuration/complexity to the iceberg project). At the same time, I see we might want to include functionality in cases where it's so commonly used that everyone would end up implementing the same functionality. At Netflix, our situation is more complicated than this would allow for, so we would likely have a custom implementation regardless. In the more general case, I would assume that instance credentials and the default credential provider chain would be sufficient. Should we just leave this out? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
