danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r536248723
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientConfigFactory.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; +import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder; + +/** + * Interface for any customization of AWS client. + * <p> + * User can provide an implementation of this factory to perform any modification to AWS clients, + * such as credentials provider, region, endpoint, http client, etc. + * See {@link AssumeRoleClientConfigFactory} as an example. + */ +public interface AwsClientConfigFactory extends CatalogConfigurable, Serializable { Review comment: Another thought (and I'm starting to think this may just make more sense) is to merge the idea of the `AwsClientConfigFactory` and `AwsClientUtil` and just make a single dynamically loadable class that would be a factory for creating the clients. All the `AwsClientUtil` does at this point is instantiate the classes and all the `AwsClientConfigFactory` does is configure it, so it would be pretty sensible to just make one that does both as a `AwsClientFactory` Then you just have `AwsClientFactory::<service>Client()` with a `DefaultAwsClientFactory` that is loaded if a custom implementation is not supplied. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
