danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r536455852
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientConfigFactory.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; +import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder; + +/** + * Interface for any customization of AWS client. + * <p> + * User can provide an implementation of this factory to perform any modification to AWS clients, + * such as credentials provider, region, endpoint, http client, etc. + * See {@link AssumeRoleClientConfigFactory} as an example. + */ +public interface AwsClientConfigFactory extends CatalogConfigurable, Serializable { Review comment: @jackye1995 I like this better, but I feel like I'm not following what value the `AwsClientConfigurer` adds at this point. It seems that `AwsClientConfigurer` interface is just a duplication of the `setDefaultsAndConfigure` in `AwsClientFactory` (they have the same signature). Why wouldn't we just drop the `AwsClientConfigurer` and dynamically load the factory? Then if someone wants to extend the configuration, they just extend `AwsClientFactory` and override the `configure` method? It seems like we would still be able to add new clients and the configure method would still apply to any of the standard client builder options. The added value this provides is that since the Factory is responsible for instantiation, we can now override that behavior (e.g. cache/reuse/proxy or force new instances for instances of the client). That may not be necessary for glue catalog as I assume there would only be one instance, but for S3FileIO it may be helpful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
