danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r536234845
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientConfigFactory.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; +import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder; + +/** + * Interface for any customization of AWS client. + * <p> + * User can provide an implementation of this factory to perform any modification to AWS clients, + * such as credentials provider, region, endpoint, http client, etc. + * See {@link AssumeRoleClientConfigFactory} as an example. + */ +public interface AwsClientConfigFactory extends CatalogConfigurable, Serializable { Review comment: While I generally agree with the dynamically loading/configuring AWS Clients, something about this implementation feels a little awkward. For example, this interface technically isn't a "Factory" per se (that's mostly just a naming issue, I still think general approach is sound. Maybe `AwsClientConfigurer`). It configures a client, but doesn't actually create anything new. Also, the actual configuration is applied via `AwsProperties::configure`, which seems a little strange. I'd suggest making a small change to move the dynamic loading into the `AwsClientUtil` (just keep the class string reference in properties) and remove the `configure` from AwsProperties (keeping logic out of the properties class). `AwsClientConfigurer` would initialize with `AwsProperties` or take it as a parameter so that configure can be called directly (not through the properties class). ########## File path: api/src/main/java/org/apache/iceberg/catalog/CatalogConfigurable.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.catalog; + +import java.util.Map; + +/** + * Interface to implement if the class will be initialized during dynamic catalog loading in engines like Spark. + * <p> + * When {@link Catalog#initialize(String catalogName, Map catalogProperties)} is called, + * The same catalog properties map is passed in to {@link CatalogConfigurable#initialize(Map catalogProperties)} + * to cascadingly complete the full catalog loading process. + */ +public interface CatalogConfigurable { Review comment: As it seems that we're standardizing on `Map<String, String>` for properties in a number of areas (catalog, table properties, etc.), It might make sense to just make this `Configuratble` and promote out side of Catalog. I'm just certain we add a lot of value by making this catalog specific. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
