gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3354121565
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -40,6 +40,7 @@ class TrackingStruct extends SupportsIndexProjection
implements Tracking, Serial
Tracking.FIRST_ROW_ID,
Tracking.DELETED_POSITIONS,
Tracking.REPLACED_POSITIONS,
+ Tracking.LATEST_COLUMN_FILE_SNAPSHOT_ID,
Review Comment:
I believe the expectation is to have the physically persisted schema fields
first and the manifest position after. Hence I placed the new field before
ROW_POSITION Note, this changes the ordinal of the existing manifest pos field,
however, since this is under development and there are no already written data
files out there, this seems fine.
The implementation of the new field in `getByPos` and `internalSet` are
meant to be in the follow-up implementation
[PR](https://github.com/apache/iceberg/pull/16321).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
