stevenzwu commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3376822391
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -65,7 +65,8 @@ public PartitionData copy() {
TrackedFile.MANIFEST_INFO,
TrackedFile.KEY_METADATA,
TrackedFile.SPLIT_OFFSETS,
- TrackedFile.EQUALITY_IDS);
+ TrackedFile.EQUALITY_IDS,
+ TrackedFile.COLUMN_FILES);
Review Comment:
don't we also need to update other methods in this class, like getByPos,
internalSet, toString?
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -212,7 +213,7 @@ private Object getByPos(int pos) {
return deletedPositions();
case 7:
return replacedPositions();
- case 8:
Review Comment:
why not complete the code for getter, setter, and toString for the new field
`LATEST_COLUMN_FILE_SNAPSHOT_ID`?
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -40,6 +40,7 @@ class TrackingStruct extends SupportsIndexProjection
implements Tracking, Serial
Tracking.FIRST_ROW_ID,
Tracking.DELETED_POSITIONS,
Tracking.REPLACED_POSITIONS,
+ Tracking.LATEST_COLUMN_FILE_SNAPSHOT_ID,
Review Comment:
Same gap will land at `case 15` in `TrackedFileStruct` for `column_files`
once the schema includes it. One small thing: in `internalSet`, the `default`
branch comment ("ignore the object, it must be from a newer version of the
format") would silently swallow values written at this version`s ordinals 8 /
15 if anything happened to set them before #16321 lands. Adding explicit `case
8:` / `case 15:` placeholders that throw (or no-op with a TODO referencing the
follow-up) would make the deferred state loud rather than silent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
