gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3379293831
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -65,7 +65,8 @@ public PartitionData copy() {
TrackedFile.MANIFEST_INFO,
TrackedFile.KEY_METADATA,
TrackedFile.SPLIT_OFFSETS,
- TrackedFile.EQUALITY_IDS);
+ TrackedFile.EQUALITY_IDS,
+ TrackedFile.COLUMN_FILES);
Review Comment:
Yes, similarly to what [we did for the other metadata
structs](https://github.com/apache/iceberg/pull/15049/changes) like
TrackedFile, Tracking, etc., I introduced the fields and schema additions first
with this PR, while making the changes in the XYZStruct implementation class in
[a follow-up](https://github.com/apache/iceberg/pull/16321). This reduces noise
so that we can agree on the actual fields and representation first without
focusing too much on implementation.
Let me know if you'd like me to merge the 2 PRs. Not sure, where to draw a
line between the two to split "API/introduction of structs" from implementation.
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -212,7 +213,7 @@ private Object getByPos(int pos) {
return deletedPositions();
case 7:
return replacedPositions();
- case 8:
Review Comment:
See my other comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
