stevenzwu commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3376822391


##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -65,7 +65,8 @@ public PartitionData copy() {
           TrackedFile.MANIFEST_INFO,
           TrackedFile.KEY_METADATA,
           TrackedFile.SPLIT_OFFSETS,
-          TrackedFile.EQUALITY_IDS);
+          TrackedFile.EQUALITY_IDS,
+          TrackedFile.COLUMN_FILES);

Review Comment:
   don't we also need to update other methods in this class, like getByPos, 
internalSet, toString? 
   
   [Earlier 
comment](https://github.com/apache/iceberg/pull/16285#discussion_r3354121565) 
mentioned a follow-up. but it is a little weird to me to not include the 
necessary implementation here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to