stevenzwu commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r3381374773
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -65,7 +65,8 @@ public PartitionData copy() {
TrackedFile.MANIFEST_INFO,
TrackedFile.KEY_METADATA,
TrackedFile.SPLIT_OFFSETS,
- TrackedFile.EQUALITY_IDS);
+ TrackedFile.EQUALITY_IDS,
+ TrackedFile.COLUMN_FILES);
Review Comment:
I see your intention now. you shifted the positions so that the existing
code can still work without more changes.
To be honest, a combined PR seems ok here because it is not very large. It
is a bit odd to see the new field added to the struct classes without other
implementations.
But I am not strongly opinionated here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
