yyanyy commented on a change in pull request #2061:
URL: https://github.com/apache/iceberg/pull/2061#discussion_r556125886
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -319,7 +319,7 @@ public static Builder builderFor(Schema schema) {
private final Schema schema;
private final List<PartitionField> fields = Lists.newArrayList();
private final Set<String> partitionNames = Sets.newHashSet();
- private Map<Integer, PartitionField> timeFields = Maps.newHashMap();
+ private Map<String, PartitionField> partitionFields = Maps.newHashMap();
Review comment:
Overall LGTM, one nit that I think `partitionFields` here would be good
to be renamed so that it's easy to tell it's just for collision detecting. Also
I wonder if we want to do this collision check for other transformations too
(like bucket, and record numBuckets in the string), so that we might be able to
combine `fields` and `partitionFields` into potentially something like a
LinkedHashMap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
