jackye1995 commented on a change in pull request #2061:
URL: https://github.com/apache/iceberg/pull/2061#discussion_r559060311
##########
File path: api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java
##########
@@ -123,6 +123,21 @@ public void
testMultipleDatePartitionsWithDifferentSourceColumns() {
PartitionSpec.builderFor(SCHEMA).hour("d").hour("another_d").build();
}
+ @Test
+ public void testMultipleIdentityPartitions() {
+
PartitionSpec.builderFor(SCHEMA).year("d").identity("id").identity("d").identity("s").build();
Review comment:
> We had people using day("ts").hour("ts") often, which is redundant so
we want to fail cases like that because it signals the user does not understand
what they are using.
Yes people also asked me about this, and there is little information about
this when people read https://iceberg.apache.org/partitioning. Let me add some
more doc in that area, plus the info about `UpdatePartitionSepc` and its SQL
extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
