yyanyy commented on a change in pull request #2061:
URL: https://github.com/apache/iceberg/pull/2061#discussion_r556230507
##########
File path: api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java
##########
@@ -123,6 +123,21 @@ public void
testMultipleDatePartitionsWithDifferentSourceColumns() {
PartitionSpec.builderFor(SCHEMA).hour("d").hour("another_d").build();
}
+ @Test
+ public void testMultipleIdentityPartitions() {
+
PartitionSpec.builderFor(SCHEMA).year("d").identity("id").identity("d").identity("s").build();
Review comment:
I was having a similar question but forgot to ask, not related to this
change - why do we not want to have two different time transforms on the same
column? Is it just because the more granular one makes the other one not so
useful (e.g. when already partitioned by `day("d")`, partition on `year("d")`
won't help with query performance)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
