jun-he commented on a change in pull request #2061:
URL: https://github.com/apache/iceberg/pull/2061#discussion_r558021203
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -319,7 +319,7 @@ public static Builder builderFor(Schema schema) {
private final Schema schema;
private final List<PartitionField> fields = Lists.newArrayList();
private final Set<String> partitionNames = Sets.newHashSet();
- private Map<Integer, PartitionField> timeFields = Maps.newHashMap();
+ private Map<String, PartitionField> partitionFields = Maps.newHashMap();
Review comment:
Thanks @yyanyy and @jackye1995 for the review.
`alwaysNull` should not be deduped as the same source field might be removed
multiple times during the spec evolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
