jun-he commented on a change in pull request #2061:
URL: https://github.com/apache/iceberg/pull/2061#discussion_r558035672
##########
File path: api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java
##########
@@ -123,6 +123,21 @@ public void
testMultipleDatePartitionsWithDifferentSourceColumns() {
PartitionSpec.builderFor(SCHEMA).hour("d").hour("another_d").build();
}
+ @Test
+ public void testMultipleIdentityPartitions() {
+
PartitionSpec.builderFor(SCHEMA).year("d").identity("id").identity("d").identity("s").build();
Review comment:
Users might not define their spec like this test, which checks one
possible code path, where dudup won't apply for date and identity and also
won't apply if identity partitions are for different source fields.
Now, partition spec update can actually add day and year for the same source
field, we may consider to drop this constraint. @rdblue how do you feel about
this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
